[m-rev.] for review: Opt-export version_array lookup and set.

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Dec 1 18:39:35 AEDT 2022



On Thu,  1 Dec 2022 17:32:11 +1100, Peter Wang <novalazy at gmail.com> wrote:
> This allows the compiler to eliminate the construction of typeinfo
> arguments for calls to version_array.lookup and version_array.set,
> when compiling with intermodule optimisation and --optimize-unused-args.
> 
> In particular, version_hash_table would previously dynamically construct
> typeinfos in order lookup or update hash table buckets.
> 
> This change improves the run time of a do-nothing build of Prince using
> mmc --make on my machine from 1.6 s to 1.43 s.

That is fine.It is also simple enough not to really need review.

Zoltan.


More information about the reviews mailing list