[m-rev.] for review: teach const_prop.m about <<u/>>u

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Dec 8 17:11:33 AEDT 2022



On Thu, 8 Dec 2022 17:03:20 +1100, Peter Wang <novalazy at gmail.com> wrote:
> Did you mean to implement the unsigned-shift-amount ops as well?

Yes, of course. Thanks for the catch.

> >  left_shift(BitsPerInt, X, Y, Z) :-
> >      BitsPerInt = bits_per_int(N),
> > +    Y >= 0,
> > +    Y < N,
> >      to_int_in_range(BitsPerInt, integer(X) << min(Y, N), Z).
> 
> min(Y, N) is redundant now.

Deleted in both places.

> Otherwise, that looks fine.

Thank you.

Zoltan.




More information about the reviews mailing list