[m-rev.] for review: Skip or delete tests that fail in low-level parallel grades.

Julien Fischer jfischer at opturion.com
Wed Nov 23 16:28:36 AEDT 2022



On Wed, 23 Nov 2022, Peter Wang wrote:

> On Wed, 23 Nov 2022 14:52:14 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>>
>>
>> On Wed, 23 Nov 2022, Peter Wang wrote:
>>
>>> Should we delete the hard_coded/parse test as well? It seems more
>>> trouble than it's worth.
>>
>> That test case is currently testing two things:
>>
>> 1. What happens when a program has a module with the same name as
>>     a browser module (its original purpose).
>>
>> 2. --linkage static
>>
>> (1) is still worthwhile. (2) is increasingly unsupported by most
>> operating systems out-of-the-box, so I think we could dispense with it.
>
> You disabled (2) in commit fd088a4f6.

So I did.

> We can delete the conditions currently surrounding STATIC_LINK_PROGS
> and rename STATIC_LINK_PROGS to DEBUG_PROGS or something.

Yes.

Julien.


More information about the reviews mailing list