[m-rev.] for review: --show-local-call-tree

Julien Fischer jfischer at opturion.com
Sun Sep 25 17:23:53 AEST 2022


On Sun, 25 Sep 2022, Zoltan Somogyi wrote:

> Add the new compiler option --show-local-call-tree.

The log message should have a brief description of what the new option does.

> doc/user_guide.texi:
> compiler/options.m:
>     As above.
> 
> NEWS:
>     Announce the new option.
> 
> compiler/hlds_call_tree.m:
>     A new module to implement the new option.
> 
> compiler/hlds.m:
> compiler/notes/compiler_design.html:
>     Add and document the new module.
> 
> compiler/mercury_compile_front_end.m:
>     Invoke the new module if the new option is set.
> 
> compiler/hlds_desc.m:
>     Add describe_pred and describe_pred_from_id. Reimplement
>     describe_proc and describe_proc_from_id in terms of those.
>     Allow callers of all four to decide whether we want the descriptions
>     to include the names of the defining module.
> 
> compiler/dead_proc_elim.m:
> compiler/ml_proc_gen.m:
> compiler/proc_gen.m:
>     Conform to the change to hlds_desc.m.
> 
> compiler/hlds_goal.m:
>     Document when it is ok form traversals of goals to assume that

s/form/for/

That looks fine otherwise.

Julien.


More information about the reviews mailing list