[m-rev.] for post-commit review: four improvements to c_util.m

Julien Fischer jfischer at opturion.com
Tue Sep 27 22:41:29 AEST 2022



On Tue, 27 Sep 2022, Zoltan Somogyi wrote:

> I am posting each diff individually to make them easier to review.
> For review by anyone. The changes get to the "stages 2 and 3 compare ok"
> stage of a bootcheck in the C# and Java grades, though I didn't have the
> patience to wait out the full bootchecks in those grades.

I haven't had a chance to look at these changes yet, but I assume that
one of them is responsible for the following:

transform_hlds.ctgc.selector.c:220:1: warning: missing braces around
initializer [-Wmissing-braces]
transform_hlds.ctgc.selector.c:220:1: warning: (near initialization for
‘mercury_var__proctable_input_steps__transform_hlds__ctgc__selector__normalize_selector_with_type_information_4_0[0]’)
[-Wmissing-braces]
transform_hlds.ctgc.selector.c:220:1: warning: initialization makes
pointer from integer without a cast [enabled by default]
transform_hlds.ctgc.selector.c:220:1: warning: (near initialization for
‘mercury_var__proctable_input_steps__transform_hlds__ctgc__selector__normalize_selector_with_type_information_4_0[0].MR_tsd_var_name’)
[enabled by default]
transform_hlds.ctgc.selector.c:220:3: error: expected ‘}’ before ‘{’
token
transform_hlds.ctgc.selector.c:261:1: warning: missing braces around
initializer [-Wmissing-braces]
transform_hlds.ctgc.selector.c:261:1: warning: (near initialization for
‘mercury_var__proctable_input_steps__transform_hlds__ctgc__selector__type_contains_subtype_1_4_0[0]’)
[-Wmissing-braces]
transform_hlds.ctgc.selector.c:261:1: warning: initialization makes
pointer from integer without a cast [enabled by default]
transform_hlds.ctgc.selector.c:261:1: warning: (near initialization for
‘mercury_var__proctable_input_steps__transform_hlds__ctgc__selector__type_contains_subtype_1_4_0[0].MR_tsd_var_name’)
[enabled by default]
transform_hlds.ctgc.selector.c:261:3: error: expected ‘}’ before ‘{’
token

Julien.


More information about the reviews mailing list