[m-rev.] for review: initialize stream readers/writers at open time for C#

Peter Wang novalazy at gmail.com
Mon Apr 24 10:51:40 AEST 2023


On Sun, 23 Apr 2023 14:53:48 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> The equivalent tasks are already done at open time with C and Java.

The diff looks fine.

> For review by Peter, but I would like other people's feedback as well
> about the idea that we should eliminate the generic "stream" type,
> and replace it with specific text_input, text_output, binary_input and binary_output
> stream types. We already have these at the user facing level, but we should have them
> one level down as well, at the defined-as-foreign-types level. (I think we should keep
> the notag wrapper types, because e.g. "binary_input_stream(0xABCD)" is more
> informative in an mdb session than just "0xABCD".)
> 
> I also think we should reverse two equivalence types, so that text_input_stream and
> text_output_stream are not synonyms for input_stream and output_stream respectively,
> but vice versa, with text_input_stream and text_output_stream being the non-equivalence
> types.
> 
> Opinions?

Both sound fine to me.

Peter


More information about the reviews mailing list