[m-rev.] for review: Cache module file names when writing dependency files.

Peter Wang novalazy at gmail.com
Thu Feb 2 16:48:30 AEDT 2023


On Thu, 02 Feb 2023 16:20:42 +1100 Julien Fischer <jfischer at opturion.com> wrote:
> > +        else
> > +            module_name_to_file_name(Globals, From, do_not_create_dirs,
> > +                Ext, ModuleName, FileName, !IO),
> > +            map.det_insert(ModuleNameExt, FileName, !Cache)
> > +        )
> > +    ).
> 
> I suggest adding a comment somewhere around saying that the rationale for this
> caching is that it saves on temporary string construction.

Done, thanks.

Peter


More information about the reviews mailing list