[m-rev.] for post-commit review: no implicit imports in .int* files

Peter Wang novalazy at gmail.com
Wed Jan 25 17:20:00 AEDT 2023


On Sat, 21 Jan 2023 06:37:09 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> Don't provide for implicit imports in .intN parse trees.
> 
> compiler/prog_item.m:
>     The ptiN_import_use_map fields in the representations of .int0, .int
>     and .int2 files had the same type as the ptms_import_use_map field
>     in the parse trees of .m files, which is where they were derived from.
>     However, while the ptms_import_use_map field needs to be able to represent
>     implicit imports, the parse trees of .int0, .int and .int2 files
>     should never include any implicit imports, and in fact any implicit
>     imports in these fields were already ignored.
> 
>     Encode the invariant that interface files never include implicit imports
>     in the types of these fields.

That looks fine.

Peter


More information about the reviews mailing list