[m-rev.] for pre-review: deleting abstract_inst

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Jul 22 05:03:25 AEST 2023


On 2023-07-20 08:39 +02:00 CEST, "Peter Wang" <novalazy at gmail.com> wrote:
>> My feeling is that we should rely on module qualification, but
>> modify it to generate somewhat more descriptive error messages,
>> such as the ones now generated by add_modes.m.
> 
> The shorter error messages from the existing compiler seem fine to me.
> Actually, I do prefer this:
> 
>     kind.m:027: In definition of inst `fi'/0:
>     kind.m:027:   error: undefined inst `f9'/0.
> 
> over this, where the important parts are a bit harder to pick out:
> 
>     kind.m:027: Error: the definition of the inst constructor `fi'/0 refers to the
>     kind.m:027:   inst constructor `f9'/0, which has no definition.

OK, I am keeping the old messages then. The attached diff, which
I will now commit, does that. For post-commit review by anyone.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.noabs
Type: application/octet-stream
Size: 3848 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230722/3619dbbc/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.noabs
Type: application/octet-stream
Size: 65300 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230722/3619dbbc/attachment-0003.obj>


More information about the reviews mailing list