[m-rev.] for post-commit review: break up det_infer_proc

Julien Fischer jfischer at opturion.com
Sat Mar 18 16:24:03 AEDT 2023


On Thu, 16 Mar 2023, Zoltan Somogyi wrote:

> Break det_infer_proc into smaller pieces.
> 
> compiler/det_analysis.m:
>     Carve three separate predicates out of det_infer_proc. Besides improving
>     readability, one of the new predicates should be useful in the fix for
>     github issue #118.
>
>     Factor out the common initial and final parts of two related but
>     different long error messages.
>
>     Improve the wording of some error messages.
>
>     Replace two separate traversals of the list of pragma exported procedures
>     with one.
> 
> tests/invalid/ho_unique_error.err_exp:
> tests/invalid/mostly_uniq1.err_exp:
> tests/invalid/mostly_uniq2.err_exp:
> tests/invalid/one_member.err_exp:
>     Expect the updated wording in error messages.

That's fine.

Julien.


More information about the reviews mailing list