[m-rev.] for review and benchmarking: speed up file name creation in write_deps_file.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Sep 7 11:16:55 AEST 2023


For review and benchmarking by Peter. Can you please
check out the effect of this diff on the benchmark you used
to evaluate the effectiveness of the cache that this diff modifies?

Julien, can you please have a look at the comment on
dir.relative_path_name_from_components? It implies
that the predicate allows the construction of pathnames such as
a/b/c/d from ["a", "b", "c", "d"], but does NOT allow
the construction of the same pathname from ["a/b/c", "d"],
even though the code does the right thing anyway.
The relationship of that code, which merely adds
the dir separator char between the components,
and the / predicate, which does a lot more,
should also be better documented.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.wdf
Type: application/octet-stream
Size: 787 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230907/19a7d8e9/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.wdf
Type: application/octet-stream
Size: 28303 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230907/19a7d8e9/attachment-0003.obj>


More information about the reviews mailing list