[m-rev.] for review of the idea: don't add unneeded parens around sym_names

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Feb 7 18:26:00 AEDT 2024


The diff is trivial, the only thing worth reviewing is whether
the cost is worth the benefit. The cost is the execution
of two tests per qualified sym_name being written out
(to e.g. intN or .*opt files). Since the value being tested
will almost always be the same (saying that the sym_name
is NOT next to a graphic symbol), the tests will be predicted
correctly in almost all cases by modern CPUs, so this cost
is minimal. The benefit is that diagnostic output that previously
contained redundant parentheses will now be slightly easier
to read.

For opinions by anyone.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ngt
Type: application/octet-stream
Size: 80555 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240207/a11ec274/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ngt
Type: application/octet-stream
Size: 386 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240207/a11ec274/attachment-0003.obj>


More information about the reviews mailing list