[m-rev.] for review: start using type_spec_constrained_preds pragmas

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Feb 9 21:09:35 AEDT 2024


On 2024-02-09 18:40 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
> What prompted my question was looking into why the instance definition
> for unboxed_reader(text_input_stream, char, io, io.error) isn't being
> put into io.opt. The answer is that we do not write out instance
> definitions that contain clauses into .opt files -- see the XXX in
> compiler/intermod_decide.m.

I never liked the idea of defining methods by clauses instead of naming
a predicate: having a name on the implementation of a method for an instance
can be useful.

The right short-term fix here is to replace the method clause with
the name of a predicate that has that clause.

>> The module comment of intermod.m should be modified to point
>> to prog_item.m. Do you want to do it, or should I?
> 
> Feel free to update it.

Attached, for your post-commit review.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.im
Type: application/octet-stream
Size: 52139 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240209/bb76555a/attachment-0001.obj>


More information about the reviews mailing list