[m-rev.] for review: .local_call_tree_full

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Feb 29 21:48:35 AEDT 2024


On 2024-02-29 21:19 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>>>     cycles, including loops, are allowed.
>>>
>>> ?
>>
>> What's the difference? To me, "cycle" and "loop" are synonyms.
> 
> Loops are usually understood to be edges that whose start and end vertex
> is the same (i.e. they are cycles, but not all cycles are loops).

I didn't know that, and I bet many readers won't know that either,
so I modified that part of the diff to:

 % This module defines a data type representing directed graphs. A directed
 % graph of type digraph(T) is logically equivalent to a set of vertices of
 % type T, and a set of edges of type pair(T). The endpoints of each edge
-% must be included in the set of vertices; cycles and loops are allowed.
+% must be included in the set of vertices. Cycles are allowed, including
+% cycles consisting of only one edge (with both ends of the edge being
+% the same node).

For your post-commit approval.

Zoltan.


More information about the reviews mailing list