[m-rev.] for review: move code for invoking commands via the shell

Julien Fischer jfischer at opturion.com
Fri Jan 5 15:46:19 AEDT 2024


On Fri, 5 Jan 2024, Zoltan Somogyi wrote:

>
> On 2024-01-05 15:02 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>> Move code for invoking commands via the shell.
>>
>> Move the code used for invoking commands via the shell out of the module_cmds
>> module and into its own module. In doing so, this moves it from the parse_tree
>> package into the libs package.
>>
>> compiler/module_cmds.m:
>>     Shift the code for invoking commands via the shell from here ...
>>
>> compiler/system_command.m:
>>     ... to here.
>
> I think the idea is fine, as is putting the new module in libs.
> I would prefer it if the name of the new module was system_cmds,
> since this maintains the existing pattern.

Done.

Julien.


More information about the reviews mailing list