[m-rev.] for review: move file copying to its own module

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Jan 5 16:58:24 AEDT 2024


On 2024-01-05 16:47 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
> 
> For review by anyone.
> 
> This diff just shifts code about; the request for review is for the new module
> name, documentation etc, plus the following proposal, which outlines the next
> changes I am intending to make.

We normally use _util as a module name component when there are several
utility predicates/functions in a module. In this case, there is only one. Is there
a realistic chance of another being added in the foreseeable future? If yes, then
the name copy_util is fine. Otherwise, I would just name the module copy_file,
since it is more descriptive.

The rest of the proposal is fine.

Zoltan.


More information about the reviews mailing list